Daniel Erez has posted comments on this change.
Change subject: webadmin: unlocalized properties in common general tab
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/CommonVmGeneralModel.java
Line 3: import org.ovirt.engine.ui.uicommonweb.dataprovider.AsyncDataProvider;
Line 4: import org.ovirt.engine.ui.uicommonweb.models.EntityModel;
Line 5: import org.ovirt.engine.ui.uicompat.ConstantsManager;
Line 6:
Line 7: public class CommonVmGeneralModel extends EntityModel {
This is useful only for classes that can extend CommonVmGeneralModel.
What if someone would like to use it elsewhere (e.g. in a dialog).
Line 8: protected String priorityToString(int value) {
Line 9: int roundedPriority = AsyncDataProvider.RoundPriority(value);
Line 10:
Line 11: if (roundedPriority == 1) {
--
To view, visit http://gerrit.ovirt.org/13884
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24151bc17538fb7489458ac0c34e10b98726812f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
