Allon Mureinik has posted comments on this change. Change subject: core: Remove unused shutdown commands. ......................................................................
Patch Set 1: I would prefer that you didn't submit this The idea is fine, but this patch leaves a lot of leftovers all over the show. The following should also be removed: 1. shutdownHost() in IVdsServer/VdsServerConnector/VdsServerWrapper 2. VDS_SHUTDOWN_ERROR in VdcBllErrors, including all it's properties/translations etc. 3. VDS_SHUTDOWN_VDS_NOT_FOUND and VDS_SHUTDOWN_NO_RESPONSE in VdcBllMessages, including all their properties/translations etc. 4. USER_VDS_SHUTDOWN and USER_FAILED_VDS_SHUTDOWN in AuditLogType, including all their properties/translations etc. -- To view, visit http://gerrit.ovirt.org/13889 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42cb8777ea1838229e05c17cae46e75305510dc6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
