Allon Mureinik has posted comments on this change. Change subject: engine: remove DBUser.desktopDevice ......................................................................
Patch Set 3: I would prefer that you didn't submit this (2 inline comments) The database upgrade isn't handled properly - see inline. Also, you should remove the USER_DESKTOP_DEVICE_SIZE constant from BusinessEntitiesDefinitions .................................................... File backend/manager/dbscripts/create_tables.sql Line 308 Line 309 Line 310 Line 311 Line 312 From what I know, you are not supposed to remove fields from the create_tables script, but rather to do this in an upgrade script. See http://www.ovirt.org/OVirt-database-upgrade-procedure for more details. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DbUser.java Line 77 Line 78 Line 79 Line 80 Line 81 I'd remove this ctor in a different patch, but it's a matter of taste, I guess. -- To view, visit http://gerrit.ovirt.org/13531 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9cdcb4893c6643ef543a2fb22cc168336e36a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Martin Beták <mbe...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
