Moti Asayag has posted comments on this change.
Change subject: engine: Configure management network at host activation
......................................................................
Patch Set 10: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateVdsCommand.java
Line 108: VdsNetworkInterface nic =
findNicForManagementNetwork(host, managementNetwork);
Line 109: if (nic != null) {
Line 110: List<VdsNetworkInterface> interfaces =
filterBondsWithoutSlaves(host.getInterfaces());
Line 111: if (interfaces.contains(nic)) {
Line 112: nic.setNetworkName(managementNetwork.getName());
It is already documented:
If lastClientInterface is none of host nic, bond or vlan, activation should
fail.
Line 113: SetupNetworksParameters parameters = new
SetupNetworksParameters();
Line 114: parameters.setVdsId(host.getId());
Line 115: parameters.setInterfaces(interfaces);
Line 116: parameters.setCheckConnectivity(true);
Line 123: }
Line 124: }
Line 125:
Line 126: private VdsNetworkInterface findNicForManagementNetwork(final VDS
host, Network network) {
Line 127: if (StringUtils.isEmpty(host.getActiveNic()) ||
network.getName().equals(host.getActiveNic())) {
Done
Line 128: return null;
Line 129: }
Line 130:
Line 131: Map<String, VdsNetworkInterface> nameToIface =
Entities.entitiesByName(host.getInterfaces());
--
To view, visit http://gerrit.ovirt.org/10919
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia82e594b888b84b3aa079cc9aa76fa0dddc59f1d
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
