Yair Zaslavsky has posted comments on this change.
Change subject: engine : Introduction of CommandManager
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandManager.java
Line 43: import org.ovirt.engine.core.utils.log.LogFactory;
Line 44: import org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil;
Line 45: import org.ovirt.engine.core.utils.transaction.TransactionSupport;
Line 46:
Line 47: public class CommandManager implements CallBack, Poller, TaskHelper {
Why does CommandManager implement Poller?
Poller is SPM-oriented.
CommandManager should be service agnostic.
Line 48:
Line 49: private static final String EXECUTION_CONTEXT_MAP_NAME =
"executionContext";
Line 50: private static final CommandManager instance = new
CommandManager();
Line 51: private static final Log log =
LogFactory.getLog(CommandManager.class);
--
To view, visit http://gerrit.ovirt.org/13152
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdd7585bfcfa6adeb761a8532218ba1aaa5e3c5d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
