Libor Spevak has posted comments on this change.
Change subject: core: Update VM status if host is not available
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 628: AuditLogDirector.log(logable, AuditLogType.VDS_FAILURE);
Line 629:
ResourceManager.getInstance().getEventListener().vdsNotResponding(vds);
Line 630:
Line 631: // update VMs states running on the host to unknown
Line 632: moveVMsToUnknown();
I put into BZ a part of log I observed. VdsNotRespondingTreatmentCommand is
called, but not always after a minute of non-responding server. My
configuration failed with: CanDoAction of action VdsNotRespondingTreatment
failed. Reasons:VDS_FENCE_DISABLED.
If it didn't fail, only migrating VMs, NOT running on a host, would be
considered, nothing else. Not sure, what operations and under what conditions
the VdsNotRespondingTreatmentCommand should support.
Line 633: }
Line 634: return true;
Line 635: }
Line 636:
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1508: vmToUpdate.getStatus().name(),
Line 1509: runningVm.getStatus().name());
Line 1510:
Line 1511: if (vmToUpdate.getStatus() == VMStatus.Unknown) {
Line 1512: logVmStatusTransionFromUnknown(vmToUpdate,
runningVm);
Here I wanted to write into log not the changed state, but that the state is
available again from Unknown to any. And as such, it is not written. By
default, nothing was written into audit log, so I did it.
Line 1513: }
Line 1514: }
Line 1515: }
Line 1516:
--
To view, visit http://gerrit.ovirt.org/13706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If569de776dfb9c97589603040e7a7f620409c361
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
