Michael Kublin has posted comments on this change.
Change subject: core: RunVmCommand.canDoAction cleanup (1)
......................................................................
Patch Set 2: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 73: @LockIdNameAttribute
Line 74: @NonTransactiveCommandAttribute
Line 75: public class RunVmCommand<T extends RunVmParams> extends
RunVmCommandBase<T>
Line 76: implements QuotaVdsDependent {
Line 77:
meanwhile a class is stalemates, so cam be final static
Line 78: private final RunVmValidator runVmValidator = new RunVmValidator();
Line 79: private static final long serialVersionUID = 3317745769686161108L;
Line 80: private String _cdImagePath = "";
Line 81: private String _floppyImagePath = "";
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 20: }
Line 21:
Line 22: return true;
Line 23: }
Line 24:
this method should not be public, it look like internal method of class
Line 25: public VmPropertiesUtils getVmPropertiesUtils() {
Line 26: return VmPropertiesUtils.getInstance();
Line 27: }
Line 28:
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
Line 269: runVmParams,
Line 270: vdsSelector,
Line 271: new SnapshotsValidator());
Line 272: }
Line 273:
same here
Line 274: private static RunVmValidator getRunVmValidator() {
Line 275: return new RunVmValidator();
Line 276: }
Line 277:
--
To view, visit http://gerrit.ovirt.org/13397
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bbdb54d150878123968893c23169de253e1ba2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
