Allon Mureinik has uploaded a new change for review.
Change subject: core: Remove LdapSeachGroupsByQuery.initFromDb
......................................................................
core: Remove LdapSeachGroupsByQuery.initFromDb
Removed LdapSeachGroupByQueryCommand.initFromDb, since all it did was
query an LdapGroup and save it into a local variable that was never used
again.
Note that this patch solves a DLS_DEAD_LOCAL_STORE FindBugs warning on
this class.
Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
1 file changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/13649/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
index c3af7c0..1980001 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapSearchGroupsByQueryCommand.java
@@ -3,7 +3,6 @@
import java.util.List;
import org.ovirt.engine.core.common.businessentities.LdapGroup;
-import org.ovirt.engine.core.dal.dbbroker.DbFacade;
public class LdapSearchGroupsByQueryCommand extends
LdapWithConfiguredCredentialsCommandBase {
@@ -27,16 +26,11 @@
if (distinguishedName != null) {
String groupName =
LdapBrokerUtils.generateGroupDisplayValue(searchResult.getDistinguishedName());
LdapGroup group = new LdapGroup(searchResult.getGuid(),
groupName, getDomain(),distinguishedName,memberOf);
- initGroupFromDb(group);
groupList.add(group);
}
}
}
setReturnValue(groupList);
setSucceeded(true);
- }
-
- private void initGroupFromDb(LdapGroup group) {
- LdapGroup dbGroup =
DbFacade.getInstance().getAdGroupDao().get(group.getid());
}
}
--
To view, visit http://gerrit.ovirt.org/13649
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I581fab9aa581a3a5093f98cc48edeaffc9080c44
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
