Sandro Bonazzola has posted comments on this change.
Change subject: sos - fixed behaviour when -a option is used
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/sos/plugins/engine.py
Line 25: self.addCopySpec("/usr/share/ovirt-engine/conf")
Line 26: self.addCopySpec("/var/log/ovirt-guest-agent")
Line 27: if (
Line 28: self.getOption("vdsmlogs") and
Line 29: self.getOption("vdsmlogs") is not True
Alon, the default for the option vdsmlogs is False. It is changed to
"/path/to/vdsmlogs" when called by log collector and it is changed to True from
sos wen called with -a switch. The fastest way here is checking it's not a
False value and it's not a True object.I could have checked the type of the
value for ensuring that it was a string and not a boolean.
Line 30: ):
Line 31: self.addCopySpec(self.getOption("vdsmlogs"))
Line 32:
Line 33: def postproc(self):
--
To view, visit http://gerrit.ovirt.org/13552
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbaec1408a581f8121339d79f66a0afcc07495b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Keith Robertson <krobe...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
