Michael Kublin has posted comments on this change.
Change subject: core: log using INFO logging level rather than ERROR
......................................................................
Patch Set 1:
"as the event queue is rather new mechanism, at least for now i prefer to keep
the stack trace - as the issues are not always easy to reproduce. at the moment
i prefer to lower the severity and keep the stacktrace, the next step would be
to change it to DEBUG level rather then provide another temporary solution, i
think that for now that's satisfying solution." - we can ask a code writer of
this mechanism, ok its me, the reason that it is error - I forgot to change it
to DEBUG.
Now every exception in log no matter with which log level it is bug by
definition and should be fixed, that's why it has name Exception.
Now, I already thought that someone will need information, so all cancelled
events are print to log:
log.infoFormat("The following operation {0} was cancelled,
because of recosntruct was run before",task.getFirst());
task.getSecond().cancel(true);
Maybe, you will stop to make workarounds or solutions that should be fixed in
the future.
--
To view, visit http://gerrit.ovirt.org/13311
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If192b3ccc5f5310de4fd80ca7fb4a7d74d52e1df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
