Daniel Erez has posted comments on this change.
Change subject: userportal, webadmin: i18n refresh 'sec'
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
I would split it into two patches (for easier review):
* Rename patch
* Translation fix patch
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/MillisecondRenderer.java
Line 31: }
Line 32:
Line 33: @Override
Line 34: public String render(final Integer seconds) {
Line 35: StringBuilder builder = new StringBuilder();
You can use CommonApplicationMessages
instead of a StringBuilder.
Line 36: builder.append(seconds / MILLI_SECOND_DIVISION);
Line 37: builder.append(' '); //$NON-NLS-1$
Line 38: builder.append(CONSTANTS.refreshRateSeconds());
Line 39: return builder.toString();
--
To view, visit http://gerrit.ovirt.org/13525
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0eadb1085e6b59239d1091d894de52ca3fc3e88a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
