Mike Kolesnik has posted comments on this change.
Change subject: engine: adding "migration" property to NetworkCluster
......................................................................
Patch Set 10: (2 inline comments)
Basically looks good, just a few small comments
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 451: NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS=Cannot ${action} ${type}.
The following VMs are actively using the Logical Network:
${NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS_LIST}. Please stop the VMs and try
again.
Line 452: NON_VM_NETWORK_CANNOT_SUPPORT_STP=Cannot ${action} ${type}. STP can
only be enabled on VM Networks.
Line 453: NETWORK_MTU_DIFFERENCES=Cannot ${action} ${type}. The following
Logical Networks don't have the same MTU value: ${NETWORK_MTU_DIFFERENCES_LIST}.
Line 454: NETWORK_MTU_OVERRIDE_NOT_SUPPORTED=Cannot ${action} ${type}.
Overriding MTU is not supported for this Data Center's compatibility version.
Line 455: MIGRATION_NETWORK_IS_NOT_SUPPORTED=Cannot ${action} ${type}.
Migration network is not supported for this cluster version.
Key should start with "ACTION_TYPE_FAILED_" to indicate these values need
replacement
Line 456: ACTION_TYPE_FAILED_MANAGEMENT_NETWORK_REQUIRED=Cannot ${action}
${type}. The management network '${NetworkName}' must be required, please
change the network to be required and try again.
Line 457:
ACTION_TYPE_FAILED_MANAGEMENT_NETWORK_ADDRESS_CANNOT_BE_CHANGED=Cannot
${action} ${type}. The management network address cannot be modified without
reinstalling the host, since this address was used to create the host's
certification.
Line 458: CANNOT_PREIEW_CURRENT_IMAGE=The currently used VM Snapshot Image
cannot be used in Preview command.
Line 459: CONFIG_UNKNOWN_KEY=Illegal configuration entry.\n\
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkClusterDaoTest.java
Line 213:
dao.setNetworkExclusivelyAsMigration(existingNetworkCluster.getClusterId(),
Line 214: existingNetworkCluster.getNetworkId());
Line 215: List<NetworkCluster> allForCluster =
dao.getAllForCluster(existingNetworkCluster.getClusterId());
Line 216: for (NetworkCluster net : allForCluster) {
Line 217: if
(net.getClusterId().equals(existingNetworkCluster.getClusterId())
You could simply compare the two "getId()" properties.
Line 218: &&
net.getNetworkId().equals(existingNetworkCluster.getNetworkId())) {
Line 219: assertTrue(net.isMigration());
Line 220: } else {
Line 221: assertFalse(net.isMigration());
--
To view, visit http://gerrit.ovirt.org/12962
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I199b1f48b6d6096db2425c594e88455640dc626c
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
