Omer Frenkel has uploaded a new change for review.

Change subject: core: minor HibernateVmCommand cleanup
......................................................................

core: minor HibernateVmCommand cleanup

removed useless call to update vm disks,
removed useless comment.

Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab
Signed-off-by: Omer Frenkel <ofren...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
1 file changed, 0 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/82/13482/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
index 11e8570..9c1afe5 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
@@ -67,7 +67,6 @@
     @Override
     public NGuid getStorageDomainId() {
         if (_storageDomainId.equals(Guid.Empty) && getVm() != null) {
-            VmHandler.updateDisksFromDb(getVm());
             List<StorageDomain> domainsInPool = 
getStorageDomainDAO().getAllForStoragePool(getVm().getStoragePoolId());
             if (domainsInPool.size() > 0) {
                 for (StorageDomain currDomain : domainsInPool) {
@@ -233,12 +232,6 @@
             retValue = false;
             
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_VM_NOT_FOUND);
         }
-        // else if (IrsClusterMonitor.Instance.DiskFreePercent <
-        // Config.FreeSpaceLow)
-        // {
-        // retValue = false;
-        // 
ReturnValue.CanDoActionMessages.Add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_SPACE_LOW.toString());
-        // }
         else if (getStorageDomainId().equals(Guid.Empty)) {
             
addCanDoActionMessage(VdcBllMessages.VM_CANNOT_SUSPEND_NO_SUITABLE_DOMAIN_FOUND);
             retValue = false;


--
To view, visit http://gerrit.ovirt.org/13482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2c7682a7b1b47e84f71fe1a6f91b3af78d799ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to