Hello Alex Lourie,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13460
to review the following change.
Change subject: packaging: Fixed creating objects in an insecure way
......................................................................
packaging: Fixed creating objects in an insecure way
This patch is using a 'validate_cert_chain' flag
instead of 'insecure' flag in the ovirt API during
creation of non-secure objects.
Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5
Bug-Url: https://bugzilla.redhat.com/886525
Signed-off-by: Alex Lourie <[email protected]>
---
M ovirt-iso-uploader.spec.in
M src/__main__.py
2 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-iso-uploader
refs/changes/60/13460/1
diff --git a/ovirt-iso-uploader.spec.in b/ovirt-iso-uploader.spec.in
index 65c3dac..be821f5 100644
--- a/ovirt-iso-uploader.spec.in
+++ b/ovirt-iso-uploader.spec.in
@@ -30,7 +30,8 @@
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}
BuildArch: noarch
Requires: python
-Requires: ovirt-engine-sdk
+Requires: ovirt-engine-sdk >= 3.2.0.10-1
+BuildRequires: gettext-devel
BuildRequires: python2-devel
%description
diff --git a/src/__main__.py b/src/__main__.py
index 748ad1d..796f425 100644
--- a/src/__main__.py
+++ b/src/__main__.py
@@ -420,12 +420,13 @@
else "https://";) + self.configuration.get("engine") + "/api"
try:
+ # If "insecure" option was provided, use it during API creation
self.api = API(
url=url,
username=self.configuration.get("user"),
password=self.configuration.get("passwd"),
ca_file=self.configuration.get("cert_file"),
- insecure=self.configuration.get("insecure")
+ validate_cert_chain=not self.configuration.get("insecure"),
)
pi = self.api.get_product_info()
--
To view, visit http://gerrit.ovirt.org/13460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I015c6b5441f0d1e33bb3aae378a59ad8557f9da5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: ovirt-iso-uploader-3.2
Gerrit-Owner: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
