Vered Volansky has posted comments on this change.
Change subject: [wip] core: move image group command
......................................................................
Patch Set 3: Looks good to me, but someone else must approve
(2 inline comments)
Please see inline comment + question.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/BackwardCompatibilityTaskCreationTest.java
Line 96: vm.setStoragePoolId(Guid.NewGuid());
Line 97: return vm;
Line 98: }
Line 99: },
Line 100: new CopyImageGroupCommand(new
MoveOrCopyImageGroupParameters()) {
Is the decision to leave MoveOrCopyImageGroupParameters as it is (not
separating) concious?
Line 101: @Override
Line 102: protected void
initContainerDetails(ImagesContainterParametersBase parameters) {
Line 103: // No op for test
Line 104: }
....................................................
Commit Message
Line 12: Reasons for that change:
Line 13: 1. When moving an image and attempting to delete with wipe - the
Line 14: operation will be faster rather then waiting for the wipe to complete.
Line 15: 2. Moving towards lowering the SPM involvement in the copy/move
process.
Line 16: 3. The engine will be able to tell on which part of the "move"
operation
s/on/in
Line 17: an error has occured.
Line 18: 4. Move operation on vdsm should be deprecated.
Line 19:
Line 20: Known issues and reasoning:
--
To view, visit http://gerrit.ovirt.org/13042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
