Yair Zaslavsky has posted comments on this change.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks ok to me.
Bare in mind you did not use the storage pool naming convention, but preferred
to use DataCenter, which IMHO is more correct (and we should one day move all
our code to this convention).
Omer, what do you think about this issue? I also added you as reviewer as this
patch is related to VMs.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQuery.java
Line 15: getParameters().getName(),
Line 16: getUserID(),
Line 17: getParameters().isFiltered());
Line 18: if (vm != null) {
Line 19: // Note that retrieving the VM is already filtered, and if
there are no permissions for it, null will be
IMHO this comment is obvious from the way you use the getByNameForDataCenter,
but as you wish.
Line 20: // returned.
Line 21: // Thus, no additional concern should be given for
permissions issues
Line 22: updateVMDetails(vm);
Line 23: getQueryReturnValue().setReturnValue(vm);
--
To view, visit http://gerrit.ovirt.org/13375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
