Vered Volansky has posted comments on this change. Change subject: core: Remove GetPermittedStorageDomainsByTemplateId ......................................................................
Patch Set 4: Looks good to me, but someone else must approve (1 inline comment) .................................................... Commit Message Line 12: This patch removes the following: Line 13: 1. The GetPermittedStorageDoaminsByTemplateIdQuery class Line 14: 2. The GetPermittedStorageDoaminsByTemplateId constant representing Line 15: it in VdcQueryType Line 16: 3. The GetPermittedStorageDomainsPByTemplateIdParameters class which s/GetPermittedStorageDomainsPByTemplateIdParameters/GetPermittedStorageDomainsByTemplateIdParameters (Redundant P there). Line 17: was only used by the removed query class. Line 18: 3. The getPermittedStorageDomainsById method in StorageDomainDAO Line 19: (which was only used by the query), its implementation, and its Line 20: test. -- To view, visit http://gerrit.ovirt.org/13230 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94f586e0daeebc0f768639b39444b30ff3101378 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
