Sandro Bonazzola has posted comments on this change. Change subject: packaging: engine-service: cleanup: merge check for running process ......................................................................
Patch Set 1: (1 inline comment) .................................................... File packaging/fedora/engine-service.py.in Line 277: Line 278: Line 279: def isProcessRunning(pid): Line 280: try: Line 281: os.kill(pid, 0) so you won't like also 'ps ax |grep pid' ... What about os.getpgid(pid) ? it works also if called by unprivileged user and raises OSError if the pid doesn't exists. Line 282: return True Line 283: except OSError: Line 284: return False Line 285: -- To view, visit http://gerrit.ovirt.org/13414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20238c634c418029c669bdf2b4b77e329b39faa1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
