Sandro Bonazzola has posted comments on this change.
Change subject: packaging: engine-service: do not fail if setsid fails
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/engine-service.py.in
Line 573: os.chdir("/")
Line 574:
Line 575: # setsid fails if already group leader
Line 576: try:
Line 577: os.setsid()
Is this really needed? We are just after a fork and looking at setsid man page
it says 'In order to be sure that setsid() will succeed, fork(2) and _exit(2),
and have the child do setsid()' and we are in the child process because we are
running there with enginePid == 0.
Line 578: except OSError:
Line 579: pass
Line 580:
Line 581: # Then open the console log and redirect standard output and
errors to it:
--
To view, visit http://gerrit.ovirt.org/13416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7092aa2d009875fcf45c560a6d480901016d5273
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
