Libor Spevak has posted comments on this change. Change subject: engine: Fixes in non plugin console invocation ......................................................................
Patch Set 2: Looks good to me, but someone else must approve So now we have a general servlet supporting any kind of attachments for the future, but nowadays it has just one use for Virt Viewer? I wonder, from what version the Virt Viewer supports the input file? Will it be a part of ActiveX plugin (packaged as CAB) or installed separately for 3.2? Do we need to distinquish more viewer types for future? Now we can assign just one application with console.vv file returned as an attachment (based on file extention). To support more viewer types, we should bind the servlet to something like: /attachment/*, not /console.vv (already discussed with Franta). Maybe not needed to do it now. -- To view, visit http://gerrit.ovirt.org/13332 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7fe6fbf274a9ac215e8f6593cc000f778a431928 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
