[Engine-patches] Change in ovirt-engine[master]: webadmin: UI-plugins MainTabActionButton CommandLocation

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: webadmin: UI-plugins MainTabActionButton CommandLocation
......................................................................

webadmin: UI-plugins MainTabActionButton CommandLocation

Add ability to set CommandLocation using addMainTabActionButton API.
getCommandLocation() applicable values:
OnlyFromFromContext/OnlyFromToolBar/ContextAndToolBar
(default value: ContextAndToolBar)

E.g.
api.addMainTabActionButton(... {
    ...
    getCommandLocation : function() {
        return "OnlyFromFromContext";
    }
});

Change-Id: I034be5af1b2dcbaad4bfce9784d74410a92fb4be
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
2 files changed, 17 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/76/13376/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java
index 13e8da6..3e689f8 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/ActionButtonInterface.java
@@ -38,4 +38,12 @@
         return getFunction("isAccessible"); //$NON-NLS-1$
     }
 
+    /**
+     * Determines action button location (CommandLocation).
+     * <p>
+     * Default return value: {@code CommandLocation.ContextAndToolBar}
+     */
+    public JsFunction getCommandLocation() {
+        return getFunction("getCommandLocation"); //$NON-NLS-1$
+    }
 }
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
index 8ceb183..f09bc33 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/api/PluginUiFunctions.java
@@ -6,6 +6,7 @@
 import org.ovirt.engine.core.compat.NGuid;
 import org.ovirt.engine.ui.common.presenter.RedrawDynamicTabContainerEvent;
 import org.ovirt.engine.ui.common.presenter.SetDynamicTabAccessibleEvent;
+import org.ovirt.engine.ui.common.widget.action.CommandLocation;
 import org.ovirt.engine.ui.common.widget.table.ActionTable;
 import org.ovirt.engine.ui.common.widget.table.HasActionTable;
 import org.ovirt.engine.ui.uicommonweb.BaseCommandTarget;
@@ -221,7 +222,7 @@
             }
         });
 
-        table.addActionButton(new WebAdminButtonDefinition<T>(label) {
+        table.addActionButton(new WebAdminButtonDefinition<T>(label, 
getCommandLocation(actionButtonInterface)) {
             @Override
             protected UICommand resolveCommand() {
                 return command;
@@ -252,6 +253,13 @@
         command.setIsAvailable(isAccessible);
     }
 
+    CommandLocation getCommandLocation(ActionButtonInterface 
actionButtonInterface) {
+        String commandLocation = 
JsFunctionResultHelper.invokeAndGetResultAsString(
+                actionButtonInterface.getCommandLocation(), null, null, 
CommandLocation.ContextAndToolBar.toString());
+
+        return CommandLocation.valueOf(commandLocation);
+    }
+
     /**
      * Shows a dialog with content loaded from the given URL.
      */


--
To view, visit http://gerrit.ovirt.org/13376
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I034be5af1b2dcbaad4bfce9784d74410a92fb4be
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches