Allon Mureinik has submitted this change and it was merged. Change subject: core: RemoveDiskCommand: only validate images once ......................................................................
core: RemoveDiskCommand: only validate images once RemoveDiskCommand.canRemoveVmImageDisk() called ImageHandler.PerformImagesChecks in a loop, for each VM attached to the disk. Since the VM checks have been extracted from ImageHandler.PerformImagesChecks in commit 69b515c3a30b0185f05b3b7d3451806f2b5b86cb, this is no longer required, can the validation can be called a single time. Change-Id: I8c0408db32415785bfe36d144b08a6f6c9f0aefc Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 18 insertions(+), 16 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c0408db32415785bfe36d144b08a6f6c9f0aefc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
