Allon Mureinik has posted comments on this change. Change subject: core: lock disks when migrating VMs ......................................................................
Patch Set 6: @Michecl: Regarding duplicate code - published a different patch and reordered them, so getPluggedDisks() will be handled in one place only. Regarding the solution itself - not sure I fully understand you. While executeCommand() is running, we have a lock to protect us, so LSM can't start while migration is running. MigrateCommand ends with VmStatus=MigrateFrom, so LSM can't start (it has a canDoAction) until the VM is UP on a different host. If I'm missing something here, please explain. -- To view, visit http://gerrit.ovirt.org/13263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9a335c3269400b355acd566c8f39e4a50fa237b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
