Libor Spevak has posted comments on this change.
Change subject: engine,webadmin: Show VM as stateless in audit log
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 455: if (mResume) {
Line 456: return getSucceeded() ? AuditLogType.USER_RESUME_VM :
AuditLogType.USER_FAILED_RESUME_VM;
Line 457: } else if (getParameters() != null &&
getParameters().getIsInternal()) {
Line 458: return getSucceeded() ?
Line 459: (statelessSnapshotExistsForVm() ?
AuditLogType.VDS_INITIATED_RUN_VM_AS_STATELESS :
AuditLogType.VDS_INITIATED_RUN_VM) :
So, this parameter is not usable at all, it is correctly set, but reset in the
second iteration from true to false.
So I suggest to use it as it is, or we can append easily new condition later
testing manual pool:
statelessSnapshotExistsForVm() && !isVMPartOfManualPool()
Line 460: AuditLogType.VDS_INITIATED_RUN_VM_FAILED;
Line 461: } else {
Line 462: return getSucceeded() ?
Line 463: (VMStatus) getActionReturnValue() ==
VMStatus.Up ?
--
To view, visit http://gerrit.ovirt.org/13344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9bb0bd88e544880406c340afb7e213041b2f845
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
