Roy Golan has uploaded a new change for review. Change subject: core: monitoring - don't handle devices for MigratingTo VMs ......................................................................
core: monitoring - don't handle devices for MigratingTo VMs There is no point of trying to update devices of migrating VM. This could wait when the VM will be up. its consistent with the same behaviour of ignoring the state of VMs with status MigratingTo. Change-Id: I33087d86c4f41d781331d1879297350d3483728f Signed-off-by: Roy Golan <rgo...@redhat.com> Bug-Url: https://bugzilla.redhat.com/922490 --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/52/13352/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java index d90985d..5be717d 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java @@ -1015,11 +1015,12 @@ * Handle changes in all VM devices */ private void handleVmDeviceChange() { - // Go over all the vms and detemine which ones require updating + // Go over all the vms and determine which ones require updating + // Update only running VMs List<String> vmsToUpdateFromVds = new ArrayList<String>(); for (VmInternalData vmInternalData : _runningVms.values()) { VmDynamic vmDynamic = vmInternalData.getVmDynamic(); - if (vmDynamic != null) { + if (vmDynamic != null && vmDynamic.getstatus() != VMStatus.MigratingTo) { VM vm = _vmDict.get(vmDynamic.getId()); if (vm != null) { String dbHash = vm.getHash(); @@ -1859,4 +1860,5 @@ public DbFacade getDbFacade() { return DbFacade.getInstance(); } + } -- To view, visit http://gerrit.ovirt.org/13352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I33087d86c4f41d781331d1879297350d3483728f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
