Alissa Bonas has posted comments on this change.
Change subject: core: add ability edit NFS path in webadmin
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageServerConnectionCommand.java
Line 116: }
Line 117:
Line 118: protected boolean isConnectionEditable(StorageDomain
storageDomain) {
Line 119: boolean isEditable =
Line 120: (storageDomain.getStorageDomainType() ==
StorageDomainType.Data || storageDomain.getStorageDomainType() ==
StorageDomainType.Master)
Sorry, not following. Is your comment misplaced?
Line 121: && storageDomain.getStatus() ==
StorageDomainStatus.Maintenance;
Line 122: return isEditable;
Line 123: }
Line 124:
Line 236: Map<String, Pair<String, String>> locks = new HashMap<String,
Pair<String, String>>();
Line 237: domains =
getStorageDomainsByConnId(getParameters().getStorageServerConnection().getid());
Line 238: if(!domains.isEmpty() && domains.size() == 1) {
Line 239: setStorageDomain(domains.get(0));
Line 240: locks.put(getStorageDomain().getId().toString(),
LockMessagesMatchUtil.STORAGE);
1. What do you mean? CDA fails for various different reasons, some of them are
not related to locks. If the configuration is not proper, then CDA will fail.
2. When there will be expansion of functionality to other storage types, this
will be investigated for each storage type and revisited if needed. Currently
it should work correctly for NFS and that's what it does.
Line 241: }
Line 242: // lock the path to NFS to avoid at the same time if some
other user tries to:
Line 243: // add new storage domain to same path or edit another
storage server connection to point to same path
Line 244:
locks.put(getParameters().getStorageServerConnection().getconnection(),
--
To view, visit http://gerrit.ovirt.org/12372
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifaff5344ff191d6bdf53cc706c7bb796167a56b3
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
