Daniel Erez has posted comments on this change. Change subject: core: LiveMigrateDisk - check isRunningOrPaused VMStatus ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java Line 35: getParameters().setDiskAlias(getDiskAlias()); Line 36: getParameters().setImageGroupID(getImageGroupId()); Line 37: getParameters().setCommandType(getActionType()); Line 38: getParameters().setTaskGroupSuccess(getParameters().getTaskGroupSuccess() Line 39: && getVm().getStatus().isRunningOrPaused()); We're checking if the VM is in down or up status beforehand (in the canDoAction). The purpose of this check is just to check whether to continue to the next step or fail the action. I.e. we want to continue the operation when the VM is on any 'running' status. Line 40: } Line 41: Line 42: /* Overridden CommandBase Methods */ Line 43: -- To view, visit http://gerrit.ovirt.org/13242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I546dbe5e225ee0db5ca190d3237b70c5a425e004 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
