Lior Vernia has posted comments on this change.

Change subject: webadmin: Modified model logic to support adding new bonds
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 431:             bondPopup.getAddress().setIsAvailable(false);
Line 432:             bondPopup.getSubnet().setIsAvailable(false);
Line 433:             bondPopup.getGateway().setIsAvailable(false);
Line 434:             bondPopup.setBootProtocolAvailable(false);
Line 435:             bondPopup.getBond().setItems(getFreeBonds());
As far as I could tell there was no such check there, seems to work.
Line 436:             
bondPopup.getBond().setSelectedItem(BondNameValidation.BOND_PREFIX);
Line 437:             bondPopup.getCommands().add(new UICommand("OK", new 
BaseCommandTarget() { //$NON-NLS-1$
Line 438: 
Line 439:                         @Override


--
To view, visit http://gerrit.ovirt.org/12534
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d3c2377ff9d95dfff1c3c416e7fc9242795e227
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to