[Engine-patches] Change in ovirt-engine[master]: webadmin, userportal: can't open permissions dialog

[derez]

Daniel Erez has uploaded a new change for review.

Change subject: webadmin,userportal: can't open permissions dialog
......................................................................

webadmin,userportal: can't open permissions dialog

Moving driver initialization to PermissionsPopupView
sub-classes (when invoked from the super-class,
the driver field of the sub-class has not yet initialized).
[changed in: I73ba1fa29629538d6160fa042113859a6bf1ae7f]

Change-Id: I2cc469cf1845982eff5a98ca1547c204ec3b87e1
Signed-off-by: Daniel Erez <de...@redhat.com>
---
M 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
M 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
3 files changed, 2 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/13301/1

diff --git 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
index ce7284e..2c8f2c4 100644
--- 
a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
+++ 
b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/permissions/AbstractPermissionsPopupView.java
@@ -103,12 +103,9 @@
         specificUserOrGroupRadio.setValue(true);
         everyoneRadio.setValue(false);
         localize(constants);
-        initDriver();
     }
 
     protected abstract void generateIds();
-
-    protected abstract void initDriver();
 
     protected abstract T doFlush();
 
diff --git 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
index 254ccc7..03b896e 100644
--- 
a/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
+++ 
b/frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/permissions/PermissionsPopupView.java
@@ -26,16 +26,12 @@
     @Inject
     public PermissionsPopupView(EventBus eventBus, ApplicationResources 
resources, ApplicationConstants constants) {
         super(eventBus, resources, constants);
+        driver.initialize(this);
     }
 
     @Override
     protected void generateIds() {
         ViewIdHandler.idHandler.generateAndSetIds(this);
-    }
-
-    @Override
-    protected void initDriver() {
-        driver.initialize(this);
     }
 
     @Override
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
index 1d11c48..68929ed 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/PermissionsPopupView.java
@@ -26,16 +26,12 @@
     @Inject
     public PermissionsPopupView(EventBus eventBus, ApplicationResources 
resources, ApplicationConstants constants) {
         super(eventBus, resources, constants);
+        driver.initialize(this);
     }
 
     @Override
     protected void generateIds() {
         ViewIdHandler.idHandler.generateAndSetIds(this);
-    }
-
-    @Override
-    protected void initDriver() {
-        driver.initialize(this);
     }
 
     @Override


--
To view, visit http://gerrit.ovirt.org/13301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cc469cf1845982eff5a98ca1547c204ec3b87e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches