Allon Mureinik has posted comments on this change. Change subject: core: Allow creating ISO domain on other file-based storages except nfs ......................................................................
Patch Set 4: Mark Regarding my comment in RemoveStoragePoolCommand.removeDomainFromPool(StrorageDomain, VDS): The current code does the following (excuse the pseudocode): if !localfs: detachDoamin else: // Silently assumes this is a data domain removeDomain After your change, when destroying a storage pool, all attached localfs ISO domains will be REMOVED, and not DETACHED. Is this the behaviour we want? -- To view, visit http://gerrit.ovirt.org/12687 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a8d3ea8ab4ac10353ec8574287458e8eb63e882 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
