ofri masad has posted comments on this change.
Change subject: core: clean-up RunVmCommand.CanDoAction (2/15)
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 688: ArrayList<String> messages =
getReturnValue().getCanDoActionMessages();
Line 689: // custom properties:
Line 690: if
(VmHandler.handleCustomPropertiesError(getVmPropertiesUtils().validateVMProperties(
Line 691: vm.getVdsGroupCompatibilityVersion(),
Line 692: vm.getStaticData()), messages)) {
Why did you remove lines 691-693 ??
That is not more readable - in fact, that is less readable
Line 693: return false;
Line 694: }
Line 695: // boot sequence:
Line 696: BootSequence boot_sequence =
(getParameters().getBootSequence() != null) ?
Line 731: return
failCanDoAction(vmDuringSnapshotResult.getMessage());
Line 732: }
Line 733:
Line 734: List<DiskImage> vmImages =
ImagesHandler.filterImageDisks(vmDisks, true, false);
Line 735: if (!ImagesHandler.filterImageDisks(vmDisks, true,
false).isEmpty()) {
why not use vmImages (created in line 734)
Line 736: storage_pool sp =
getStoragePoolDAO().get(vm.getStoragePoolId());
Line 737: ValidationResult spUpResult = new
StoragePoolValidator(sp).isUp();
Line 738: if (!spUpResult.isValid()) {
Line 739: return failCanDoAction(spUpResult.getMessage());
--
To view, visit http://gerrit.ovirt.org/13112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I87ce576fbf82ad5b1f677d3cef7113b4cb9fd1e1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
