Allon Mureinik has uploaded a new change for review. Change subject: core: Remove unused IsStoragePoolWithSameNameExist ......................................................................
core: Remove unused IsStoragePoolWithSameNameExist Removed the unused IsStoragePoolWithSameNameExistQuery. This patch removes the following: 1. The unused IsStoragePoolWithSameNameExistQuery class. 2. The IsStoragePoolWithSameNameExistParameters class only used by the aforementioned query class. 3. The IsStoragePoolWithSameNameExistQuery constant in VdcQueryType corresponding to the removed class. Change-Id: I08bba52c8795bba0535d4651c0b6532dd4d523c9 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsStoragePoolWithSameNameExistQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 37 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/13227/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsStoragePoolWithSameNameExistQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsStoragePoolWithSameNameExistQuery.java deleted file mode 100644 index 66ca41e..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsStoragePoolWithSameNameExistQuery.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.bll; - -import org.ovirt.engine.core.common.queries.IsStoragePoolWithSameNameExistParameters; -import org.ovirt.engine.core.dal.dbbroker.DbFacade; - - -public class IsStoragePoolWithSameNameExistQuery<P extends IsStoragePoolWithSameNameExistParameters> extends QueriesCommandBase<P> { - public IsStoragePoolWithSameNameExistQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue(DbFacade.getInstance() - .getStoragePoolDao() - .getByName(getParameters().getStoragePoolName()) != null); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java deleted file mode 100644 index 7623227..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java +++ /dev/null @@ -1,18 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -public class IsStoragePoolWithSameNameExistParameters extends VdcQueryParametersBase { - private static final long serialVersionUID = 8408352366968606070L; - - public IsStoragePoolWithSameNameExistParameters(String storagePoolName) { - this.storagePoolName = storagePoolName; - } - - private String storagePoolName; - - public String getStoragePoolName() { - return storagePoolName; - } - - public IsStoragePoolWithSameNameExistParameters() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 0c9799b..1bdb96b 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -207,7 +207,6 @@ GetVmTemplatesWithPermittedAction(VdcQueryAuthType.User), // Storage - IsStoragePoolWithSameNameExist, GetStorageDomainById(VdcQueryAuthType.User), GetStorageServerConnectionById, GetStoragePoolById(VdcQueryAuthType.User), -- To view, visit http://gerrit.ovirt.org/13227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I08bba52c8795bba0535d4651c0b6532dd4d523c9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches