Allon Mureinik has uploaded a new change for review. Change subject: core: Remove unused GetVGInfoQuery ......................................................................
core: Remove unused GetVGInfoQuery Removed the unused GetVGInfoiQuery. This patch removes the following: 1. The unused GetVGInfoQuery class. 2. The VGQueryParameterBase class only used by GetVGInfoQuery. 3. The GetVGInfo constant in VdcQueryType corresponding to the removed class. Change-Id: I1e43d685ffd2c0664094c024f883c853d7edfc75 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVGInfoQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 50 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/25/13225/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVGInfoQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVGInfoQuery.java deleted file mode 100644 index 60721ed..0000000 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVGInfoQuery.java +++ /dev/null @@ -1,24 +0,0 @@ -package org.ovirt.engine.core.bll.storage; - -import org.ovirt.engine.core.bll.*; -import org.ovirt.engine.core.common.businessentities.*; -import org.ovirt.engine.core.common.queries.*; -import org.ovirt.engine.core.common.vdscommands.*; - -public class GetVGInfoQuery<P extends VGQueryParametersBase> extends QueriesCommandBase<P> { - public GetVGInfoQuery(P parameters) { - super(parameters); - } - - @Override - protected void executeQueryCommand() { - getQueryReturnValue().setReturnValue( - (java.util.ArrayList<LUNs>) Backend - .getInstance() - .getResourceManager() - .RunVdsCommand( - VDSCommandType.GetVGInfo, - new GetVGInfoVDSCommandParameters(getParameters().getVdsId(), getParameters() - .getVGId())).getReturnValue()); - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java deleted file mode 100644 index a9da8f7..0000000 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VGQueryParametersBase.java +++ /dev/null @@ -1,25 +0,0 @@ -package org.ovirt.engine.core.common.queries; - -import org.ovirt.engine.core.compat.*; - -public class VGQueryParametersBase extends VdsIdParametersBase { - private static final long serialVersionUID = -4612413633577153266L; - - private String privateVGId; - - public String getVGId() { - return privateVGId; - } - - private void setVGId(String value) { - privateVGId = value; - } - - public VGQueryParametersBase(String vgID, Guid vdsId) { - super(vdsId); - setVGId(vgID); - } - - public VGQueryParametersBase() { - } -} diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java index 5bc028b..c02cab7 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java @@ -217,7 +217,6 @@ GetStorageDomainsByImageId, GetStorageServerConnections, GetVgList, - GetVGInfo, GetDeviceList, DiscoverSendTargets, GetStorageSessionsList, -- To view, visit http://gerrit.ovirt.org/13225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1e43d685ffd2c0664094c024f883c853d7edfc75 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches