Alon Bar-Lev has posted comments on this change. Change subject: engine: use autoclose to clean up vdsdeploy ......................................................................
Patch Set 1: I would prefer that you didn't submit this Allon, I am not aware we approve using features of jdk-1.7 in code yet, if this feature is approve a wide spread patch should be added to use these features. Doing that per class method is not correct. If we are to use jdk-1.7 autoclose, and there is no wide spread patch for this, I will prepare a decent patch to host-deploy to handle all *Stream, ssh, to use this. Now Laszlo, I already responded to your question, the finalize use is only safe guard to prevent resource leak if someone by accident (which is not the case here) forget to call close in its finally block. -- To view, visit http://gerrit.ovirt.org/13090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43338f9d2d5bfb36c220f1fd19810f8c7436a543 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
