Hello Vojtech Szocs,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/13094
to review the following change.
Change subject: webadmin,userportal: Fix compile error when using gwtdev profile
......................................................................
webadmin,userportal: Fix compile error when using gwtdev profile
Trying to debug WebAdmin/UserPortal via GWT Hosted Mode:
$ mvn gwt:debug -Pgwt-admin,gwt-user,gwtdev -Dgwt.noserver=true
results in Java compilation error, since GwtCachingFilter
calls java.text.DateFormat methods that are currently not
emulated via custom java.text.DateFormat GWT override.
This patch adds no-op (empty) implementations of required
methods to fix this error.
Note that GWT overrides affect GWT Hosted Mode only;
debugging server-side module (e.g. GwtCachingFilter in
'frontend' module) as Remote Java Application attaches
to server-side JVM that is unaware of GWT overrides.
Change-Id: Ic0cc662037f13ca8c19c565ebb082b8b8b82c7bc
Signed-off-by: Vojtech Szocs <vsz...@redhat.com>
---
M
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
A
frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/TimeZone.java
2 files changed, 20 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/94/13094/1
diff --git
a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
index d633bfd..f73a5e3 100644
---
a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
+++
b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/text/DateFormat.java
@@ -24,5 +24,14 @@
* Constant for default style pattern. Its value is MEDIUM.
*/
public static final int DEFAULT = MEDIUM;
-
+
+ public String format(java.util.Date date) {
+ // No-op, don't use this method in client code
+ return null;
+ }
+
+ public void setTimeZone(java.util.TimeZone zone) {
+ // No-op, don't use this method in client code
+ }
+
}
diff --git
a/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/TimeZone.java
b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/TimeZone.java
new file mode 100644
index 0000000..457fdb0
--- /dev/null
+++
b/frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/java/util/TimeZone.java
@@ -0,0 +1,10 @@
+package java.util;
+
+public class TimeZone {
+
+ public static TimeZone getTimeZone(String ID) {
+ // No-op, don't use this method in client code
+ return null;
+ }
+
+}
--
To view, visit http://gerrit.ovirt.org/13094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0cc662037f13ca8c19c565ebb082b8b8b82c7bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
