Yair Zaslavsky has posted comments on this change. Change subject: engine : User can see events which don't belong to him ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File backend/manager/dbscripts/audit_log_sp.sql Line 122: FROM audit_log a Line 123: WHERE NOT deleted AND Line 124: (NOT v_is_filtered OR EXISTS (SELECT 1 Line 125: FROM user_vm_permissions_view pv, user_object_permissions_view dpv Line 126: WHERE pv.user_id = '40a6b52c-993d-49b2-8550-2469e6b25f57' AND pv.entity_id = a.vm_id AND pv.entity_id = dpv.entity_id) shouldn't this be v_user_id? Line 127: OR EXISTS (SELECT 1 Line 128: FROM user_vm_template_permissions_view pv, user_object_permissions_view dpv Line 129: WHERE pv.user_id = '40a6b52c-993d-49b2-8550-2469e6b25f57' AND pv.entity_id = a.vm_template_id AND pv.entity_id = dpv.entity_id) Line 130: OR EXISTS (SELECT 1 -- To view, visit http://gerrit.ovirt.org/13091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b7a6691f6cfa2ca1c0d0d90294ecd93781fce38 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
