Laszlo Hornyak has posted comments on this change. Change subject: engine: enums should be small caps ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 431: <xs:element name="level" type="xs:int" minOccurs="0"/> Line 432: <xs:element name="name" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 433: <xs:element name="speed" type="xs:decimal" minOccurs="0" maxOccurs="1"/> Line 434: <xs:element name="cpu_tune" type="CpuTune" minOccurs="0" maxOccurs="1"/> Line 435: <xs:element name="mode" type="xs:string" minOccurs="0" maxOccurs="1" default="custom"/> ok, I will just remove and we will see Line 436: </xs:sequence> Line 437: <xs:attribute name="id" type="xs:string"/> Line 438: </xs:complexType> Line 439: -- To view, visit http://gerrit.ovirt.org/12453 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie2d793c9049f81af741c2a4a3694465ea2d423ea Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches