Michael Pasternak has posted comments on this change.
Change subject: restapi: Rest API for brick advanced details
......................................................................
Patch Set 7: Looks good to me, approved
(1 inline comment)
Well done Sahina!,
tiny 'reuse' comment, but you're done from my perspective.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBrickResource.java
Line 80: }
Line 81:
Line 82: @Override
Line 83: protected GlusterBrick doPopulate(GlusterBrick model,
GlusterBrickEntity entity) {
Line 84: return populateAdvancedDetails(model,entity);
you could reuse this code from the parent
Line 85: }
Line 86:
Line 87: private GlusterBrick populateAdvancedDetails(GlusterBrick model,
GlusterBrickEntity entity) {
Line 88:
--
To view, visit http://gerrit.ovirt.org/11391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie219c7cf59fec8a21a54f34959ee5966eed7d524
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
