Doron Fediuck has posted comments on this change.
Change subject: pki: use relative lock file
......................................................................
Patch Set 2: (2 inline comments)
First of all this is more than changing a path location,
this is also removing rollbacks. In most cases it would be much better to have
it in separate patches.
Also, can you please explain why did you remove the rollback?
....................................................
File backend/manager/conf/ca/SignReq.sh
Line 56: timeout=$8
Line 57: if [ -z "$timeout" ]; then
Line 58: timeout=20
Line 59: fi
Line 60:
Why did you remove the trap?
This is supposed to do a proper cleanup in case someone kills it.
Your change will cause everything to stuck.
Line 61: {
Line 62: # Wait for lock on $lock_file (fd 200) for $timeout seconds
Line 63: flock -e -w $timeout 200 || die "Timeout waiting for lock.
Giving up"
Line 64: sign
Line 60:
Line 61: {
Line 62: # Wait for lock on $lock_file (fd 200) for $timeout seconds
Line 63: flock -e -w $timeout 200 || die "Timeout waiting for lock.
Giving up"
Line 64: sign
s/tab/spaces/
Line 65: result=$?
Line 66:
Line 67: } 200>$lock_file
Line 68:
--
To view, visit http://gerrit.ovirt.org/13030
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4274778254167db8f632908a9bdcc0d6ad284b3e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
