Alon Bar-Lev has posted comments on this change. Change subject: packaging: use conf.d notation for setup settings ......................................................................
Patch Set 4: (1 inline comment) .................................................... File packaging/fedora/setup/engine-setup.py Line 2094: https=controller.CONF["HTTPS_PORT"]) Line 2095: Line 2096: def _editSysconfigJava(): Line 2097: utils.editEngineSysconfigJava( Line 2098: javaHome=controller.CONF["JAVA_HOME"]) python is eating this correctly, but I will fix... :) Line 2099: Line 2100: def startRhevmDbRelatedServices(): Line 2101: """ Line 2102: bring back any service we stopped -- To view, visit http://gerrit.ovirt.org/12666 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib05f8c3b21c2b1146bda5b257e347a91d0521bce Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches