Yair Zaslavsky has uploaded a new change for review. Change subject: core: Improving job messages for event subscription commands ......................................................................
core: Improving job messages for event subscription commands Improving job messages for AddEventSubscription and RemoveEventSubscription Change-Id: Ic263b8f59c36fc97f1733317edbd17dbaa5487dd Bug-Url: https://bugzilla.redhat.com/919045 Signed-off-by: Yair Zaslavsky <yzasl...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/41/13041/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java index 0898dd8..ed34940 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EventSubscriptionCommandBase.java @@ -1,6 +1,7 @@ package org.ovirt.engine.core.bll; import java.util.List; +import java.util.Map; import org.apache.commons.lang.StringUtils; import org.ovirt.engine.core.common.EventNotificationMethods; @@ -19,6 +20,16 @@ super(parameters); } + @Override + public Map<String, String> getJobMessageProperties() { + if (jobProperties == null) { + jobProperties = super.getJobMessageProperties(); + } + jobProperties.put("address", getParameters().getEventSubscriber().getmethod_address()); + jobProperties.put("eventtype", getParameters().getEventSubscriber().getevent_up_name()); + return jobProperties; + } + /** * Validates the notification method. * diff --git a/backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties b/backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties index 80c57ba..6a02a4e 100644 --- a/backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties +++ b/backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties @@ -86,6 +86,8 @@ job.AddBricksToGlusterVolume=Adding Bricks to Gluster Volume ${GlusterVolume} job.RemoveGlusterServer=Removing Gluster Server ${VDS} job.RegisterDisk=Registering Disk ${DiskAlias} +job.AddEventSubscription=Adding subscriber ${Address} to event type ${EventType} +job.RemoveEventSubscription=Removing subscriber ${Address} from event type ${EventType} # Step types step.VALIDATING=Validating -- To view, visit http://gerrit.ovirt.org/13041 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic263b8f59c36fc97f1733317edbd17dbaa5487dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
