Juan Hernandez has posted comments on this change. Change subject: packaging: engine-encrypt-passwd.sh as standalone script ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/tools/src/main/shell/engine-encrypt-passwd.sh Line 1 Line 2 Line 3 Line 4 If I understand correctly you are implementing a file system transaction, so if you don't succeed installation then you just rollback the transaction and nothing is changed. However, if this script is not intended to be used outside of the installation then it would be better to remove it and to the same thing from the installation program directly. .................................................... File packaging/fedora/setup/basedefs.py Line 48: DIR_VAR_LOG="/var/log" Line 49: DIR_VAR_LIB="/var/lib" Line 50: DIR_LOG="%s/ovirt-engine/" % DIR_VAR_LOG Line 51: DIR_CONFIG="%s/ovirt-engine/conf" % DIR_USR_SHARE Line 52: DIR_JBOSS="/usr/share/jboss-as" Currently I can change the JBOSS_HOME parameter in the configuration file before running the installation program and everything will use the new setting. Is that true after this change? Line 53: DIR_JBOSS_RESOURCES="%s/ovirt-engine/resources/jboss" % DIR_USR_SHARE Line 54: DIR_KERBEROS="%s/ovirt-engine/kerberos" % DIR_USR_SHARE Line 55: DIR_ENGINE="/usr/share/%s" % (ENGINE_SERVICE_NAME) Line 56: DIR_PLUGINS="%s/ovirt-engine/scripts/plugins" % DIR_USR_SHARE -- To view, visit http://gerrit.ovirt.org/13031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b748fc787d44b2e877412f3107719d607b7a4ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
