Vojtech Szocs has posted comments on this change. Change subject: core: provided cleared frontend logging ......................................................................
Patch Set 4: Looks good to me, but someone else must approve Looks good but I have some minor comment: why use "new StringBuilder(int)" instead of just "new StringBuilder()"? [assuming the overall string length will be relatively small, there shouldn't be too much array resizing involved] -- To view, visit http://gerrit.ovirt.org/12559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
