Alon Bar-Lev has posted comments on this change.
Change subject: core: introduce osinfo service instead of Config values
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/osinfo/LibosinfoClient.java
Line 86:
Line 87: String options = "-Djava.rmi.server.hostname=localhost";
Line 88: String mainClassName =
"org.ovirt.engine.core.osinfo.server.LibosinfoServer";
Line 89:
Line 90: builder.command(java, "-cp", classpath, options,
mainClassName);
I disagree. This is independent service that has nothing to do with the enigne,
it can be taken as-is to any other project, and share nothing in code. Had this
project provided this kind of service we would not execute it within jboss.
Although for java people it is easier to close all edges within the java
domain, it is harder to maintain these kind of integration later on. A lot of
solution had gone this way and then worked hard to perform the split.
Anyway, the best alternative is to just read the XML... this is plain xml, why
can't we just read it?!?! I really don't understand this move... it just
complicate the integration and adds unneeded technologies.
Line 91: return builder;
Line 92: }
Line 93:
Line 94: private ProcessBuilder buildShellProcessCmd() {
--
To view, visit http://gerrit.ovirt.org/12936
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd75679a1a1af5d5a0925e181b5dfd6e87574a75
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
