Yair Zaslavsky has posted comments on this change.

Change subject: core: Failed install DB during oVirt-setup...
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

minor comment about commit msg.

....................................................
File backend/manager/tools/dbutils/encodingvalidator.sh
Line 21:     printf "\t-s SERVERNAME - The database servername for the database 
 (def. ${SERVERNAME})\n"
Line 22:     printf "\t-p PORT       - The database port for the database       
 (def. ${PORT})\n"
Line 23:     printf "\t-u USERNAME   - The admin username for the database.\n"
Line 24:     printf "\t-l LOGFILE    - The logfile for capturing output         
 (def. ${LOGFILE})\n"
Line 25:     printf "\t-f            - Fix the templat1 database encoding to be 
UTF8.\n"
s/templat/template
Line 26:     printf "\t-v            - Turn on verbosity                        
 (WARNING: lots of output)\n"
Line 27:     printf "\t-h            - This help text.\n"
Line 28:     printf "\n"
Line 29:     popd>/dev/null


--
To view, visit http://gerrit.ovirt.org/12966
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74dd62ec2c0f96d719b15848da4e08d8f6cc5068
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to