Eli Mesika has posted comments on this change.
Change subject: db: execute privileged upgrade operation only if required
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File backend/manager/dbscripts/dbfunctions.sh
Line 92: # required only if we upgrade from old database
Line 93: # as it requires special privileges, so
Line 94: # before execution check if actually required
Line 95: #
Line 96: CMD="select count(*) from pg_proc where proname =
lower('uuid_nil');"
lower is redundant since you are using a constant lower value
Line 97: if [ "$(execute_command "$CMD" ${DATABASE} ${SERVERNAME} ${PORT} |
sed -e 's/ //g' -e '/^$/d')" != 0 ]; then
Line 98: psql -U postgres -h ${SERVERNAME} -p ${PORT} -f
drop_old_uuid_functions.sql ${DATABASE} > /dev/null
Line 99: fi
Line 100: # recreate generic functions
--
To view, visit http://gerrit.ovirt.org/12949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66da7066b26e9aa18df75e4a36e520c495a5880f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
