Vojtech Szocs has posted comments on this change. Change subject: webadmin: Failure message popup window text unified ......................................................................
Patch Set 3: I'm OK with changes in patch set 3, you could also remove CommonApplicationMessages.uiCommonFrontendFailure() method entirely, as it's used only in FrontendFailureEventListener. With regard to removing "Error ..." prefixes, this should be done in a separate patch. The purpose of such prefixes was to categorize different kinds of errors (besides providing the error message itself), so they aren't completely useless in my opinion. -- To view, visit http://gerrit.ovirt.org/11860 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I80a9b71e1a3e6f97342184e71ffcbb7cee1df4e9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Libor Spevak <lspe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
