Vojtech Szocs has posted comments on this change.

Change subject: webadmin,userportal: Improve form-based sub tabs
......................................................................


Patch Set 6: Verified

> There's a problem with general sub-tabs that have less than 3 columns

Fixed, the problem was caused by HorizontalPanel's <td> element for item label 
not having width set explicitly.

Verified that form-based sub tabs with less than 3 columns have proper item 
label widths.

> Clusters -> General sub-tab: Might look better using a SplitLayoutPanel (e.g. 
> VMs -> Network Interfaces / Snapshots)

Agreed, will be done in a separate patch.

[BZ link is now included in the commit message.]

--
To view, visit http://gerrit.ovirt.org/12325
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b2f2577b1b488d5514dc05c2590a2bb53fcfe4f
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Alexander Wels <aw...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to