Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Cluster policy details moved to a new sub-tab
......................................................................
Patch Set 3: Verified; Looks good to me, but someone else must approve
(1 inline comment)
small note, I think that 'Cluster Node Type' label should be visible only in
'both' mode.
giving +1 (minor comments).
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
Line 179: if (ClusterPolicyModel.highLimitPowerSaving == null)
Line 180: {
Line 181:
AsyncDataProvider.GetHighUtilizationForPowerSave(_asyncQuery);
Line 182: }
Line 183:
we can clean it up a little and use AsyncDataProvider.GetConfigValuePreConverted
instead of this old code and static members
Line 184: setOverCommitTime(new EntityModel());
Line 185:
Line 186: // Set all properties according to default selected algorithm:
Line 187: SelectionAlgorithmChanged();
--
To view, visit http://gerrit.ovirt.org/12945
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I600b1614f6e8a1a82b254b76c7713678cfb9e557
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
