Maor Lipchuk has posted comments on this change. Change subject: core: Remove image when VDSM returns not exist. ......................................................................
Patch Set 6: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java Line 80: try { Line 81: VDSReturnValue vdsReturnValue = performImageVdsmOperation(); Line 82: creationInfo = vdsReturnValue.getCreationInfo(); Line 83: } catch (VdcBLLException e) { Line 84: if (e.getErrorCode() == VdcBllErrors.ImageDoesNotExistInDomainError) { I will add a log here, that will explain what happened. Creating a dummy task, since we got image does not exists. Which should end the command as unknown task at the end. Line 85: creationInfo = Line 86: new AsyncTaskCreationInfo(Guid.NewGuid(), Line 87: AsyncTaskType.deleteImage, Line 88: getDiskImage().getStoragePoolId().getValue()); -- To view, visit http://gerrit.ovirt.org/12077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36915c44e65e20e3ce222683650a562603e4bb05 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches